[ovs-dev] [PATCH] datapath-windows: Fix possible null dereference in ipfragment

Alin Serdean aserdean at cloudbasesolutions.com
Wed May 17 13:54:55 UTC 2017


Found using static analysis tools.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
---
 datapath-windows/ovsext/IpFragment.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/IpFragment.c b/datapath-windows/ovsext/IpFragment.c
index 675c32e..0874cb9 100644
--- a/datapath-windows/ovsext/IpFragment.c
+++ b/datapath-windows/ovsext/IpFragment.c
@@ -343,7 +343,7 @@ OvsProcessIpv4Fragment(POVS_SWITCH_CONTEXT switchContext,
         }
         POVS_FRAGMENT_LIST next = entry->head;
         POVS_FRAGMENT_LIST prev = entry->tail;
-        if (prev != NULL || prev->offset < offset) {
+        if (prev != NULL && prev->offset < offset) {
             next = NULL;
             goto found;
         }
-- 
2.10.2.windows.1


More information about the dev mailing list