[ovs-dev] [PATCH] datapath-windows: Report success for conntrack actions over frags

[Anand Kumar]

Hi Alin,

Thank you for identifying and fixing issue in fragmenatation. 

Acked-by: Anand Kumar <kumaranand at vmware.com>

Regards,
Anand Kumar

On 5/17/17, 6:43 AM, "ovs-dev-bounces at openvswitch.org on behalf of Alin Serdean" <ovs-dev-bounces at openvswitch.org on behalf of aserdean at cloudbasesolutions.com> wrote:

    When a conntrack action is applied over an IP fragment we pend the fragment
    which will be consumed later. This should be transparent to the userspace.
    
    Report that the action was applied successfully so it does not spam
    the ovs-vswitchd log.
    
    Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
    ---
     datapath-windows/ovsext/Actions.c | 5 +++++
     1 file changed, 5 insertions(+)
    
    diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c
    index ebfb8a3..31b4514 100644
    --- a/datapath-windows/ovsext/Actions.c
    +++ b/datapath-windows/ovsext/Actions.c
    @@ -2032,6 +2032,11 @@ OvsDoExecuteActions(POVS_SWITCH_CONTEXT switchContext,
                     if (status != NDIS_STATUS_PENDING) {
                         OVS_LOG_ERROR("CT Action failed");
                         dropReason = L"OVS-conntrack action failed";
    +                } else {
    +                    /* We added a new pending NBL to be consumed later.
    +                     * Report to the userspace that the action applied
    +                     * successfully */
    +                    status = NDIS_STATUS_SUCCESS;
                     }
                     goto dropit;
                 } else if (oldNbl != ovsFwdCtx.curNbl) {
    -- 
    2.10.2.windows.1
    _______________________________________________
    dev mailing list
    dev at openvswitch.org
    https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=Y5x5a2PGs19T3vg4xFJVJ7Shc9w2EwzDuDLwbuky5B8&s=xKibgF9Sm5mhbBW9MLFgBhslRtDQ1EQX-fyo6ILGPic&e=