[ovs-dev] [PATCH v3 1/1] dpif-netdev: The pmd-*-show commands will show info in core order

Ben Pfaff blp at ovn.org
Thu May 18 22:41:14 UTC 2017


On Tue, May 09, 2017 at 09:08:54AM +0200, Eelco Chaudron wrote:
> The "ovs-appctl dpif-netdev/pmd-rxq-show" and "ovs-appctl
> dpif-netdev/pmd-stats-show" commands show their output per core_id,
> sorted on the hash location. My OCD was kicking in when using these
> commands, hence this change to display them in natural core_id order.
> 
> In addition I had to change a test case that would fail if the cores
> where not in order in the hash list. This is due to OVS assigning
> queues to cores based on the order in the hash list. The test case now
> checks if any core has the set of queues in the given order.
> 
> Manually tested this on my setup, and ran clang-analyze.
> 
> Signed-off-by: Eelco Chaudron <echaudro at redhat.com>

Thanks a lot!  Little things like this eventually add up to make the UI
nicer.  I applied this to master.


More information about the dev mailing list