[ovs-dev] [PATCH] doc: Resolve pep8 warnings in conf.py

Ben Pfaff blp at ovn.org
Fri May 19 16:13:54 UTC 2017


On Fri, May 19, 2017 at 10:01:19AM +0000, Bodireddy, Bhanuprakash wrote:
> >-----Original Message-----
> >From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> >bounces at openvswitch.org] On Behalf Of Stephen Finucane
> >Sent: Friday, May 19, 2017 10:15 AM
> >To: dev at openvswitch.org
> >Subject: [ovs-dev] [PATCH] doc: Resolve pep8 warnings in conf.py
> >
> >flake8 doesn't like us redefining variables in loops.
> >
> >Signed-off-by: Stephen Finucane <stephen at that.guru>
> >Reported-by: Bhanuprakash Bodireddy
> ><bhanuprakash.bodireddy at intel.com>
> >Fixes: f15010f ("doc: Reduce duplication in 'man_pages'")
> >Cc: Ben Pfaff <blp at ovn.org>
> >---
> > Documentation/conf.py | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/Documentation/conf.py b/Documentation/conf.py index
> >d70ee6b..77c4df5 100644
> >--- a/Documentation/conf.py
> >+++ b/Documentation/conf.py
> >@@ -121,6 +121,6 @@ _man_pages = [
> >
> > # Generate list of (path, name, description, [author, ...], section)  man_pages
> >= [
> >-    ('ref/%s' % filename, filename.split('.', 1)[0],
> >-     description, [author], filename.split('.', 1)[1])
> >-    for filename, description in _man_pages]
> >+    ('ref/%s' % file_name, file_name.split('.', 1)[0],
> >+     description, [author], file_name.split('.', 1)[1])
> >+    for file_name, description in _man_pages]
> 
> Acked by: Bhanuprakash Bodireddy <Bhanuprakash.bodireddy at intel.com>

Thanks Stephen and Bhanu.  I applied this to master.


More information about the dev mailing list