[ovs-dev] [PATCH v6 2/5] userspace: L3 tunnel support for GRE and LISP

[Jan Scheurich]

> I think that parse_gre_header() should perhaps be pickier about the
> Ethertypes it accepts, since values below 0x600 are not valid
> Ethertypes and sometimes they are used for special purposes, for example
> OpenFlow uses 0x5ff to mean that the frame lacks an Ethertype.

I agree. OVS could just drop packets from GRE tunnels with GRE protocols < 0x600.

> 
> I recommend adding an item to NEWS to mention this new user-visible
> feature.

What about:

diff --git a/NEWS b/NEWS
index 25eb477..bbed787 100644
--- a/NEWS
+++ b/NEWS
@@ -45,6 +45,12 @@ Post-v2.7.0
    - Fedora Packaging:
      * OVN services are no longer restarted automatically after upgrade.
    - Add --cleanup option to command 'ovs-appctl exit' (see ovs-vswitchd(8)).
+   - L3 tunneling:
+     * Add "layer3" options for tunnel ports that support non-Ethernet (L3)
+       payload (GRE, VXLAN-GPE).
+     * New vxlan tunnel extension "gpe" to support VXLAN-GPE tunnels.
+     * Transparently pop and push Ethernet headers at transmit/reception
+       of packets to/from L3 tunnels.

 v2.7.0 - 21 Feb 2017
 ---------------------

> 
> Ideally, some new documentation would explain how layer 2 and 3 packets
> interact.

I am planning for proper documentation along the lines of the Google doc as part of the overall PTAP and generic Encap/Decap patch complex.

Can you recommend a good authoring tool for the .rst format used in OVS lately?

BR, Jan