[ovs-dev] [PATCH] tests: fix hanging test on windows

Joe Stringer joe at ovn.org
Mon May 22 23:39:11 UTC 2017


On 22 May 2017 at 05:18, Alin Serdean <aserdean at cloudbasesolutions.com> wrote:
> 'multiple bridges share a controller' hangs on windows because it is
> lacking the exit information (it will hang when the test has finished)
>
> Introduce a pidfile to 'ovs-testcontroller' and end it on exit based on
> the pidfile.
>
> Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>

Hi Alin,

"on_exit" will queue up a command to be run at the end of the test
run, regardless of success or failure. As such, I think that this
should be run immediately after the launch of ovs-testcontroller.
Otherwise it's possible that something else in the test fails before
the end, and ovs-testcontroller is not cleaned up.


More information about the dev mailing list