[ovs-dev] [PATCH 0/5] Fix unaligned pointer values reported by clang 4.0.
Greg Rose
gvrose8192 at gmail.com
Wed May 24 19:18:07 UTC 2017
On Tue, 2017-05-23 at 16:02 -0700, Joe Stringer wrote:
> Clang 4.0 has added some new warnings around taking the address of packed
> members of structures which may result in unaligned pointer values. This series
> addresses the resulting compilation failures (reported via -Werror).
>
> Joe Stringer (5):
> odp-execute: Fix unaligned eth_addr access.
> ofproto-dpif: Fix unaligned eth_addr access.
> test-hash: Don't check bit 2048.
> test-hash: Fix unaligned memory access.
> test-hash: Reuse structs/functions in 256B check.
>
> lib/odp-execute.c | 19 +++++++++++--
> ofproto/ofproto-dpif.c | 12 +++++---
> tests/test-hash.c | 74 ++++++++++++++++++++++++++++++--------------------
> 3 files changed, 70 insertions(+), 35 deletions(-)
>
Generally all the patches in this series look fine to me but I have a
few questions...
So are these patches needed for ARM and/or Sparc? Do we have any
reports of unaligned accesses from people working on those CPU
architectures? I guess more to the point, do *we* have any ARM or Sparc
systems with which we can test?
Thanks,
- Greg
More information about the dev
mailing list