[ovs-dev] [PATCH] ovs-ofctl: Close pcap file at end of ofctl_ofp_parse_pcap().
Ben Pfaff
blp at ovn.org
Fri May 26 23:04:12 UTC 2017
Seem wise even if not mandatory.
Found by Coverity.
Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763047&defectInstanceId=4305314&mergedDefectId=180420
Signed-off-by: Ben Pfaff <blp at ovn.org>
---
utilities/ovs-ofctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index 1a5e2345b7d4..140cd18e617a 100644
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -2484,6 +2484,7 @@ ofctl_ofp_parse_pcap(struct ovs_cmdl_context *ctx)
dp_packet_delete(packet);
}
tcp_reader_close(reader);
+ fclose(file);
}
static void
--
2.10.2
More information about the dev
mailing list