[ovs-dev] [PATCH] ovs-lldp: Remove dead store to TTL configuration.

Ben Pfaff blp at ovn.org
Sat May 27 03:21:13 UTC 2017


Apparently this has always used LLDP_CHASSIS_TTL as a fixed TTL, so we
might as well delete the statement just before that tries to dynamically
calculate it.

Found by Coverity.

CC: Dennis Flynn <drflynn at avaya.com>
Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762612&defectInstanceId=4304824&mergedDefectId=180431
Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 lib/ovs-lldp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/ovs-lldp.c b/lib/ovs-lldp.c
index 55fc2320312c..711f9b4fe635 100644
--- a/lib/ovs-lldp.c
+++ b/lib/ovs-lldp.c
@@ -797,8 +797,6 @@ lldp_create(const struct netdev *netdev,
     lchassis->c_id = &mac->ea[0];
 
     ovs_list_init(&lchassis->c_mgmt);
-    lchassis->c_ttl = lldp->lldpd->g_config.c_tx_interval *
-                      lldp->lldpd->g_config.c_tx_hold;
     lchassis->c_ttl = LLDP_CHASSIS_TTL;
     lldpd_assign_cfg_to_protocols(lldp->lldpd);
     ovs_list_init(&lldp->lldpd->g_chassis);
-- 
2.10.2



More information about the dev mailing list