[ovs-dev] [PATCH] ofproto-dpif-ipfix: Fix severe memory leak in ipfix_send_template_msgs().

Ben Pfaff blp at ovn.org
Sat May 27 05:00:59 UTC 2017


On Fri, May 26, 2017 at 09:14:21PM -0700, Ben Pfaff wrote:
> This fixes a seemingly severe memory leak in ipfix_send_template_msgs().
> This function was setting up a buffer with a stub, but only the first 4
> or 8 bytes of the stub were actually used because the "sizeof" call used
> to size it was actually getting the size of a pointer.  It never freed
> the buffer, leaking it.
> 
> Additionally, after this code sent a template message, it started over
> from the same undersized stub, leaking another block of memory.
> 
> This commit fixes both problems.
> 
> Found by Coverity.
> 
> CC: Romain Lenglet <romain.lenglet at oracle.com>

...and a bounce.  Romain is no longer at Oracle.  How interesting.


More information about the dev mailing list