[ovs-dev] [PATCH] dpctl: Fix memory leak on error path.

[Greg Rose]

On Sat, 2017-05-27 at 21:17 -0700, Ben Pfaff wrote:
> On Sat, May 27, 2017 at 06:26:00PM -0700, Greg Rose wrote:
> > On Fri, 2017-05-26 at 16:07 -0700, Ben Pfaff wrote:
> > > Found by Coverity.
> > > 
> > > Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762909&defectInstanceId=4305311&mergedDefectId=180415
> > > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > > ---
> > >  lib/dpctl.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/lib/dpctl.c b/lib/dpctl.c
> > > index 11be85706db5..c0da3108943d 100644
> > > --- a/lib/dpctl.c
> > > +++ b/lib/dpctl.c
> > > @@ -1,5 +1,5 @@
> > >  /*
> > > - * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016 Nicira, Inc.
> > > + * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Nicira, Inc.
> > 
> > OK, last time I'll comment on this I swear!  :)
> > 
> > Better something like Copyright (c) 2008-2017
> > 
> > Otherwise someday the line will be really long.
> 
> I use an Emacs setting that automatically updates copyright notices when
> I modify a file.  It seems that there's a setting to make it use ranges,
> so I've turned that on now.
> 
> (It takes several years of working on a piece of software before this
> becomes an issue!)

LOL, yes.  Good news is that the piece of software has lasted that long!
That says something.

Thanks!

- Greg