[ovs-dev] [PATCH] ovn-northd: Avoid null deref for missing outport in build_static_route_flow().

[Ben Pfaff]

Thanks for the review!  I applied this to master, branch-2.7, and
branch-2.6.

On Mon, May 29, 2017 at 12:38:41PM +0200, Miguel Angel Ajo Pelayo wrote:
> Acked-By: Miguel Angel Ajo <majopela at redhat.com>
> 
> On Sat, May 27, 2017 at 7:39 AM, Ben Pfaff <blp at ovn.org> wrote:
> 
> > Found by Coverity.
> >
> > Reported-at: https://scan3.coverity.com/reports.htm#v16889/p10449/
> > fileInstanceId=14763080&defectInstanceId=4305186&mergedDefectId=179788
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> >  ovn/northd/ovn-northd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> > index 94bbe7c489b7..4d4930855c39 100644
> > --- a/ovn/northd/ovn-northd.c
> > +++ b/ovn/northd/ovn-northd.c
> > @@ -3966,7 +3966,7 @@ build_static_route_flow(struct hmap *lflows, struct
> > ovn_datapath *od,
> >          }
> >      }
> >
> > -     if (!lrp_addr_s) {
> > +    if (!out_port || !lrp_addr_s) {
> >          /* There is no matched out port. */
> >          static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);
> >          VLOG_WARN_RL(&rl, "No path for static route %s; next hop %s",
> > --
> > 2.10.2
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >