[ovs-dev] [PATCH] checkpatch: Be more careful about checking function names.

Ben Pfaff blp at ovn.org
Tue May 30 17:33:36 UTC 2017


On Tue, May 30, 2017 at 09:40:58AM -0700, Joe Stringer wrote:
> On 26 May 2017 at 15:17, Ben Pfaff <blp at ovn.org> wrote:
> > On Fri, May 26, 2017 at 01:40:13PM -0700, Joe Stringer wrote:
> >> On 26 May 2017 at 11:32, Ben Pfaff <blp at ovn.org> wrote:
> >> > This code would complain about the use of ovs_strerror because it
> >> > matches [^x]strerror, and the same was true in many other similar cases.
> >> >
> >> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> >>
> >> Ah, good catch. I think this will match on mentions within comments too though?
> >
> > Does this change make a difference in that?  I think that most of the
> > checks will trigger on comments.
> 
> Ah, no. At some point I was considering narrowing the expression but
> it isn't there at the moment.
> 
> Acked-by: Joe Stringer <joe at ovn.org>

Thanks.  I applied this to master.


More information about the dev mailing list