[ovs-dev] [PATCH v3 1/5] rstp: Init a recursive mutex for rstp.

Ben Pfaff blp at ovn.org
Wed May 31 23:01:49 UTC 2017


On Fri, May 19, 2017 at 12:20:39AM -0700, nickcooper-zhangtonghao wrote:
> * This patch will be used for next patch. The 'rstp/show' command,
> which uses the mutex, calls functions which also use the mutex.
> We should init it as a recursive mutex.
> 
> * Because of recursive mutex, this patch remove the OVS_EXCLUDED in
> list/rstp.[ch] files.
> 
> * Some rstp tests of OvS, which run with ovstest, does not run rstp_init
> in the bridge_init. We should call rstp_init when creating the rstp
> and stp also do that, otherwise tests fail.
> 
> Signed-off-by: nickcooper-zhangtonghao <nic at opencloud.tech>

I think I'd prefer to add internal versions of functions that don't take
the locks, instead.  Did you consider that approach?


More information about the dev mailing list