[ovs-dev] [PATCH] ovn-northd: Fix ping failure of vlan networks.

Ben Pfaff blp at ovn.org
Wed May 31 23:42:56 UTC 2017


On Mon, May 22, 2017 at 07:39:22PM +0800, wang.qianyu at zte.com.cn wrote:
> There are two computer node, each have one vm. And the two vms in 
> indifferent vlan networks. The ping between the vms is not success.
> 
> The reason is that, acl of to-localnet port or from-localnet port is
> signed to contrack. So the pair of icmp request and reply have different
> zone id in one ovs node. This makes the ct state not correct.
> 
> This patch do the modification that localnet port do not use ct.
> 
> Signed-off-by: wangqianyu <wang.qianyu at zte.com.cn>

This patch was word-wrapped, but I was able to deal with that.

I don't exactly understand the problem.  Does conntrack not work at all
with packets that go to/from localnet ports?  Or does it have something
to do with VLAN tags?

Please document the new flows in ovn-northd.8.xml.

Also, checkpatch reported the following:

ERROR: Improper whitespace around control block
#17 FILE: b/ovn/northd/ovn-northd.c:1355:
                if(!strcmp(nbsp->type, "localnet")) {

ERROR: Improper whitespace around control block
#28 FILE: b/ovn/northd/ovn-northd.c:2637:
        if(od->localnet_port) {

WARNING: Line length is >79-characters long
#32 FILE: b/ovn/northd/ovn-northd.c:2641:
            ds_put_format(&match_in, "ip && inport == %s", od->localnet_port->json_key);

WARNING: Line length is >79-characters long
#33 FILE: b/ovn/northd/ovn-northd.c:2642:
            ds_put_format(&match_out, "ip && outport == %s", od->localnet_port->json_key);

Thanks a lot for working on OVN!


More information about the dev mailing list