[ovs-dev] [PATCH] datapath: Remove redundant check for IFF_NO_QUEUE
Greg Rose
gvrose8192 at gmail.com
Wed Nov 1 15:43:20 UTC 2017
On 10/30/2017 06:13 PM, fukaige wrote:
> From: Kaige Fu <fukaige at huawei.com>
>
> IFF_NO_QUEUE is checked twice. This cause a situation
> that HAVE_IFF_NO_QUEUE is defined no matter whether
> the flag IFF_NO_QUEUE is defined in kernel or not.
>
> Signed-off-by: Kaige Fu <fukaige at huawei.com>
> ---
> datapath/linux/compat/include/linux/netdevice.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/datapath/linux/compat/include/linux/netdevice.h b/datapath/linux/compat/include/linux/netdevice.h
> index a5d4ee8..3c3cf42 100644
> --- a/datapath/linux/compat/include/linux/netdevice.h
> +++ b/datapath/linux/compat/include/linux/netdevice.h
> @@ -22,9 +22,6 @@ struct net;
> #define IFF_LIVE_ADDR_CHANGE 0
> #endif
>
> -#ifndef IFF_NO_QUEUE
> -#define IFF_NO_QUEUE 0
> -#endif
> #ifndef IFF_OPENVSWITCH
> #define IFF_OPENVSWITCH 0
> #endif
>
Looks correct to me.
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>
More information about the dev
mailing list