[ovs-dev] [PATCH] rhel.rst: Add python-sphinx as a dependency.

[Aaron Conole]

Guru Shetty <guru at ovn.org> writes:

> On 31 October 2017 at 13:06, Aaron Conole <aconole at redhat.com> wrote:
>
>  Ben Pfaff <blp at ovn.org> writes:
>
>  > On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:
>  >> Ben Pfaff <blp at ovn.org> writes:
>  >>
>  >> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:
>  >> >> Signed-off-by: Gurucharan Shetty <guru at ovn.org>
>  >> >> ---
>  >> >>  Documentation/intro/install/rhel.rst | 2 +-
>  >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>  >> >>
>  >> >> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
>  >> >> index 86c5cf3..aff6ccf 100644
>  >> >> --- a/Documentation/intro/install/rhel.rst
>  >> >> +++ b/Documentation/intro/install/rhel.rst
>  >> >> @@ -76,7 +76,7 @@ the below command::
>  >> >>
>  >> >>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
>  >> >>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
>  >> >> -        libtool checkpolicy selinux-policy-devel
>  >> >> +        libtool checkpolicy selinux-policy-devel python-sphinx
>  >> >
>  >> > For Debian, we just recommend installing the build-dependencies listed
>  >> > in debian/control.  That has the advantage that it can't get out of
>  >> > date.  It has the disadvantage, though, that it's not easy to cut and
>  >> > paste (although "apt-get build-dep openvswitch" usually does the trick).
>  >> > Maybe "yum" has some mode that installs dependencies from a spec file?
>  >>
>  >> For 'yum' distributions:
>  >>
>  >>   yum-builddep
>  >>
>  >> For 'dnf' distributions (newer Fedora, and future RHEL versions):
>  >>
>  >>   dnf builddep
>  >
>  > Would it be reasonable to change rhel.rst to recommend using one of
>  > those tools, to ease future maintenance?
>
>  Sure.  Something like below?  I don't know about the wordsmithing, so
>  I'll defer that to Guru.
>
>  ---
>
>  diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/
>  rhel.rst
>  index 86c5cf3..36bb661 100644
>  --- a/Documentation/intro/install/rhel.rst
>  +++ b/Documentation/intro/install/rhel.rst
>  @@ -72,11 +72,14 @@ Build Requirements
>
>   To compile the RPMs, you will need to install the packages described in the
>   :doc:`general` along with some additional packages. These can be installed with
>  -the below command::
>  +the below command for ``yum`` based distributions (but note that the
>  +openvswitch source RPM must be available somewhere)::
>
> Expecting source rpm while building the rpm, looks like is not going to happen for majority of the
> cases. I took it that we will need it if "yum-builddep openvswitch" needs to succeed?.

I didn't think about.  As I understand, `yum-builddep` requires the
source RPM.  That means we would need to build the SRPM (rpmbuild -bs)
first.

Maybe it would be better to document using the `mock` tool for this job
(since it should be included, and is designed for building the RPMs from
a clean chroot).  The upside is that it should be the same regardless of
RHEL/Fedora/CentOS.  I'm not sure about SUSE or other rpm-based
distributions, though.

>  -    $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
>  -        kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
>  -        libtool checkpolicy selinux-policy-devel
>  +    $ yum-builddep openvswitch
>  +
>  +For ``dnf`` based distributions, use the following command::
>  +
>  +    $ dnf builddep rhel/openvswitch-fedora.spec
>
>   .. _rhel-bootstrapping:
>  --