[ovs-dev] [PATCH] ovs-lib: dont't purge corrupted DB

Ben Pfaff blp at ovn.org
Fri Nov 3 21:50:59 UTC 2017


On Wed, Sep 27, 2017 at 09:32:52PM +0000, Mark Michelson wrote:
> LGTM
> 
> On Wed, Sep 27, 2017 at 8:46 AM Matteo Croce <mcroce at redhat.com> wrote:
> 
> > In ovs-lib there is a function named upgrade_db which tries to convert a
> > database after OVS {up,down}grades. This function uses ovsdb-tool to
> > check if the DB needs to be upgraded. If the upgrade fails,
> > it purges the DB and create an empty one.
> > ovsdb-tool returns "yes" or "no" to indicate if the DB needs upgrading,
> > but if the DB is corrupted it returns a list of errors.
> > Change a condition from "!= no" to "= yes" because in case of DB
> > corruption upgrade_db would purge the existing DB without writing
> > anything in the logs.
> >
> > Signed-off-by: Matteo Croce <mcroce at redhat.com>
> >
> Acked-by: Mark Michelson <mmichels at redhat.com>

Thanks Matteo and Mark, I applied this to master and branch-2.8.  If
you're concerned about older versions, let me know and I can backport it
farther.


More information about the dev mailing list