[ovs-dev] [PATCH 1/2] NSH: Minor bugfixes

Ben Pfaff blp at ovn.org
Tue Nov 7 00:22:26 UTC 2017


On Mon, Nov 06, 2017 at 11:24:54PM +0000, Jan Scheurich wrote:
> - Fix 2 incorrect length checks
> - Remove unnecessary limit of MD length to 16 bytes
> - Remove incorrect comments stating MD format 2 was not supported
> - Pad metadata in encap_nsh with zeroes to multiple of 4 bytes
> 
> Signed-off-by: Jan Scheurich <jan.scheurich at ericsson.com>

Thanks for the bug fixes.

Instead of using ROUND_UP and manual arithmetic to compute a pad size, I
suggest using the PAD_SIZE macro.

Otherwise, this looks good to me.

Is this suitable for backporting to branch-2.8?

Thanks,

Ben.


More information about the dev mailing list