[ovs-dev] [PATCH] vswitchd: doc the option dst_port
通天晓0280
dongj at dtdream.com
Wed Nov 8 09:30:15 UTC 2017
It seems this patch broke OVS compiling,there is an recent error while compiling OVS in networking-ovn CI. [1]
0xC2A0C2A0 appeared between words "Optional." and "The" [2].
[1]http://logs.openstack.org/03/518203/3/check/networking-ovn-tempest-dsvm-ovs-master/d021028/logs/devstacklog.txt.gz#_2017-11-08_07_08_57_141[2]https://github.com/openvswitch/ovs/blob/master/vswitchd/vswitch.xml#L2370------------------------------------------------------------------From:Ben Pfaff <blp at ovn.org>Time:2017 Nov 8 (Wed) 12:23To:duanjiong <djduanjiong at gmail.com>Cc:dev <dev at openvswitch.org>Subject:Re: [ovs-dev] [PATCH] vswitchd: doc the option dst_port
On Mon, Nov 06, 2017 at 01:43:23PM +0800, duanjiong wrote:
> Otherwise the user does not know how to change it
>
> Signed-off-by: Duan Jiong <djduanjiong at gmail.com>
> ---
> vswitchd/vswitch.xml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> index d7f6839..c4e3d62 100644
> --- a/vswitchd/vswitch.xml
> +++ b/vswitchd/vswitch.xml
> @@ -2367,6 +2367,10 @@
> </ul>
> </column>
>
> + <column name="options" key="dst_port">
> + Optional. The tunnel transport layer destination port.
> + </column>
> +
Thanks for the patch. It did not apply properly and it took me a long
time to figure out why. It is because it is corrupted by using
nonbreaking spaces (U+00A0) where spaces (U+0020) must be used. I fixed
that and applied this to master, first adding a little more information:
--8<--------------------------cut here-------------------------->8--
From: duanjiong <djduanjiong at gmail.com>
Date: Mon, 6 Nov 2017 13:43:23 +0800
Subject: [PATCH] vswitchd: Document option dst_port.
Otherwise the user does not know how to change it
Signed-off-by: Duan Jiong <djduanjiong at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
---
vswitchd/vswitch.xml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index d7f68393b25e..20e516cfe8d3 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -2367,6 +2367,11 @@
</ul>
</column>
+ <column name="options" key="dst_port">
+ Optional. The tunnel transport layer destination port, for UDP and TCP
+ based tunnel protocols (Geneve, VXLAN, LISP, and STT).
+ </column>
+
<column name="options" key="key">
Optional. Shorthand to set <code>in_key</code> and
<code>out_key</code> at the same time.
--
2.10.2
_______________________________________________
dev mailing list
dev at openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
More information about the dev
mailing list