[ovs-dev] [PATCH v3 0/3] netdev-dpdk: mempool management: Leaks & Refactoring.

Stokes, Ian ian.stokes at intel.com
Fri Nov 10 20:11:55 UTC 2017


> Fixed memory leak in mempool management code + a big clean up.
> 
> First patch is simple fix for leaks while the second one simplifies the
> whole mempool management by removing redundant struct dpdk_mp.
> 
> To be honest, patch #2 removes all the buggy conditions fixed in the first
> patch, but I think that it'll be very unclear where was that leak if we
> apply only the third patch.
> 
> Patch #3 removes old macro which is not used since per-port mempool
> allocation implemented.
> 

Thanks for working on this Ilya, I've pushed the series to the dpdk_merge branch.

> Version 3:
> 	* Extended commit messages. (Ian)
> 
> Version 2:
> 	* Dropped "mp_name leak" patch as already applied.
> 	* Rebased on current master (one minor mechanical conflict
> 	  because of 'struct netdev_dpdk's format change.)
> 	  I kept all the 'Acked-by's from v1.
> 
> Ilya Maximets (3):
>   netdev-dpdk: Fix dpdk_mp leak in case of EEXIST.
>   netdev-dpdk: Factor out struct dpdk_mp.
>   netdev-dpdk: Remove unused MAX_NB_MBUF.
> 
>  lib/netdev-dpdk.c | 202 +++++++++++++++++++------------------------------
> -----
>  1 file changed, 69 insertions(+), 133 deletions(-)
> 
> --
> 2.7.4



More information about the dev mailing list