[ovs-dev] [PATCH v2 3/3] netdev-dpdk: Fix mempool creation with large MTU.

Stokes, Ian ian.stokes at intel.com
Wed Nov 15 15:09:17 UTC 2017


> Thanks for this fix Ilya.
> 
> I've tested this, and can confirm that it resolves a SEGV that previously
> occurred in the case of 'large' MTU values (in the case of my test, 9710).
> 
> Acked-by: Mark Kavanagh <mark.b.kavanagh at intel.com>
> Tested-by: Mark Kavanagh <mark.b.kavanagh at intel.com>
> 

Thanks all for the work on this, I'll look to push this to the dpdk merge branch today.

Ian
> Best,
> Mark
> 
> >---
> > lib/netdev-dpdk.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index
> >75856bc..dc210cc 100644
> >--- a/lib/netdev-dpdk.c
> >+++ b/lib/netdev-dpdk.c
> >@@ -510,7 +510,8 @@ dpdk_mp_create(struct netdev_dpdk *dev, int mtu)
> >     do {
> >         /* Full DPDK memory pool name must be unique and cannot be
> >          * longer than RTE_MEMPOOL_NAMESIZE. */
> >-        int ret = snprintf(mp_name, RTE_MEMPOOL_NAMESIZE,
> "ovs_%x_%d_%d_%u",
> >+        int ret = snprintf(mp_name, RTE_MEMPOOL_NAMESIZE,
> >+                           "ovs%08x%02d%05d%07u",
> >                            hash, socket_id, mtu, n_mbufs);
> >         if (ret < 0 || ret >= RTE_MEMPOOL_NAMESIZE) {
> >             VLOG_DBG("snprintf returned %d. "
> >--
> >2.7.4



More information about the dev mailing list