[ovs-dev] [PATCH] netdev-linux: do not remove ingress qdisc when disable policing.

Guoshuai Li ligs at dtdream.com
Thu Nov 16 06:39:17 UTC 2017


I'm sorry for my mistake. I did not think so much

I actually want to express the meaning is

tc qdisc should not be operated when never enabled policing.

Because my question is this:

    step1. Configure the tc command at the ovs-port

       # tc qdisc add dev ovs-port ingress

       # tc qdisc show dev ovs-port
          qdisc noqueue 0: root refcnt 2
          qdisc ingress ffff: parent ffff:fff1 ----------------

    step2. Then refresh the ovs-port state, qdisc ingress is removed.

       # ip link set ovs-port down

       # ip link set ovs-port up

       # tc qdisc show dev ovs-port
          qdisc noqueue 0: root refcnt 2


I want to fix this problem, but accidentally broke the original 
function.  I'm very sorry.

I sent a new version to fix it:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-November/340971.html




> After this patch is applied, it looks to me like removing policing
> becomes a complete no-op.  That cannot be right; it means that policing,
> once enabled, cannot be disabled.
>
> Can you help me understand better?
>
> Thanks,
>
> Ben.



More information about the dev mailing list