[ovs-dev] [PATCH v3] odp-execute: Skip processing actions when batch is emptied
Ben Pfaff
blp at ovn.org
Thu Nov 30 19:01:19 UTC 2017
On Thu, Nov 30, 2017 at 05:37:57AM +0000, Vishal Deep Ajmera wrote:
> Today in OVS, when errors are encountered during the execution
> of an action the entire batch of packets may be deleted (for e.g.
> in processing push_tnl_action, if the port is not found in the
> port_cache of PMD). The remaining actions continue to be executed
> even though there are no packets to be processed.
>
> It is assumed that the code dealing with each action checks that
> the batch is not empty before executing. Crashes may occur if the
> assumption is not met.
>
> The patch makes OVS skip processing of further actions from the
> action-set once a batch is emptied. Doing so centralizes the check
> in one place and avoids the possibility of crashes.
>
> This change DOES NOT fix any existing bug in the code, only a
> precautionary measure to avoid crashes if new actions does not
> take care of empty batches.
>
> Signed-off-by: Vishal Deep Ajmera <vishal.deep.ajmera at ericsson.com>
Thanks.
I applied this to master.
More information about the dev
mailing list