[ovs-dev] [PATCHv2] netdev: netdev_get_etheraddr is not functioning as advertised.

Ben Pfaff blp at ovn.org
Thu Nov 30 21:51:05 UTC 2017


On Thu, Nov 30, 2017 at 08:31:24AM -0800, Yifeng Sun wrote:
> netdev_get_etheraddr claims to clear 'mac' on error, but it fails to do so.
> When looking further into both netdev_windows_get_etheraddr() and
> netdev_linux_get_etheraddr(), 'mac' is also not cleared. This will lead to
> usage of uninitialised ofputil_phy_port.hw_addr.
> 
> v1 -> v2: fixed a bug in v1 found by Ben, thanks Ben.
> 
> Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>

Thanks, applied to master and backported as far as 2.4.


More information about the dev mailing list