[ovs-dev] [PATCH 5/7] ofproto: Remove break after OVS_NOT_REACHED.

Bhanuprakash Bodireddy bhanuprakash.bodireddy at intel.com
Sun Oct 1 07:57:38 UTC 2017


The break statement would never be executed as OVS_NOT_REACHED()
internally invokes abort() and causes process termination.

Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy at intel.com>
---
 ofproto/ofproto-dpif-ipfix.c | 1 -
 ofproto/ofproto-dpif-xlate.c | 2 --
 2 files changed, 3 deletions(-)

diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c
index 472c272..538faff 100644
--- a/ofproto/ofproto-dpif-ipfix.c
+++ b/ofproto/ofproto-dpif-ipfix.c
@@ -1314,7 +1314,6 @@ ipfix_def_options_template_fields(enum ipfix_options_template opt_tmpl_type,
     case NUM_IPFIX_OPTIONS_TEMPLATE:
     default:
         OVS_NOT_REACHED();
-        break;
     }
 
     return 0;
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index d320d57..0a71855 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -3229,7 +3229,6 @@ propagate_tunnel_data_to_flow(struct xlate_ctx *ctx, struct eth_addr dmac,
     case __OVS_VPORT_TYPE_MAX:
     default:
         OVS_NOT_REACHED();
-        break;
     }
     /*
      * Update base_flow first followed by flow as the dst_flow gets modified
@@ -5951,7 +5950,6 @@ xlate_generic_encap_action(struct xlate_ctx *ctx,
         default:
             /* New packet type was checked during decoding. */
             OVS_NOT_REACHED();
-            break;
     }
 
     if (!ctx->error) {
-- 
2.4.11



More information about the dev mailing list