[ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT parameters.

Kevin Traynor ktraynor at redhat.com
Mon Oct 2 10:46:23 UTC 2017


On 09/26/2017 01:35 PM, antonio.fischetti at intel.com wrote:
> This series adds two new commands to allow read/write of
> some of the CT configuration parameters. This could be
> used for maintenance purposes or to find a better tuning
> of the current setup.
> 

Hi Antonio. I don't think that helps people not too familiar with
conntrack understand why the commands are needed and what cases they
will help with. Also, I think there should be some documentation to
guide the user on when to use the new commands. I'm not making comment
on the usefulness or not of the commands but there's a need to explain
why you are making the changes and guide the user on them.

thanks,
Kevin.

> V2: Reworked based on comments.
> V1: First implementation.
> 
> Fischetti, Antonio (4):
>   dpctl: Add a comment to functions retrieving the datapath name.
>   conntrack: add commands to r/w CT parameters.
>   conntrack: r/w upper limit connection value.
>   conntrack: read current nr of connections.
> 
>  lib/conntrack.c     |  90 +++++++++++++++++++++++++++++++++++++++++++++
>  lib/conntrack.h     |   3 ++
>  lib/ct-dpif.c       |  28 ++++++++++++++
>  lib/ct-dpif.h       |   2 +
>  lib/dpctl.c         | 104 +++++++++++++++++++++++++++++++++++++++++++++++++++-
>  lib/dpif-netdev.c   |  19 ++++++++++
>  lib/dpif-netlink.c  |   2 +
>  lib/dpif-provider.h |   4 ++
>  8 files changed, 251 insertions(+), 1 deletion(-)
> 



More information about the dev mailing list