[ovs-dev] [PATCH 1/2] ovn-northd: Refactor logic for logical port 'up' state update

Miguel Angel Ajo Pelayo majopela at redhat.com
Mon Oct 2 11:33:19 UTC 2017


Acked-by: Miguel Angel Ajo <majopela at redhat.com>

On Fri, Sep 29, 2017 at 8:06 PM, Mark Michelson <mmichels at redhat.com> wrote:

> This looks much better. I wrote out the truth table to confirm that the
> functionality is the same.
>
> On Fri, Sep 29, 2017 at 10:06 AM Jakub Sitnicki <jkbs at redhat.com> wrote:
>
> > No functional change.  Make it obvious that we determine the logical
> > port 'up' state by checking for bound chassis, and update the NB DB only
> > when state has not been set yet or current state is different.
> >
> > Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
> >
> Acked-by: Mark Michelson <mmichels at redhat.com>
>
> > ---
> >  ovn/northd/ovn-northd.c | 7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> > index 2db2380..37651a0 100644
> > --- a/ovn/northd/ovn-northd.c
> > +++ b/ovn/northd/ovn-northd.c
> > @@ -5980,11 +5980,8 @@ update_logical_port_status(struct northd_context
> > *ctx)
> >              continue;
> >          }
> >
> > -        if (sb->chassis && (!nbsp->up || !*nbsp->up)) {
> > -            bool up = true;
> > -            nbrec_logical_switch_port_set_up(nbsp, &up, 1);
> > -        } else if (!sb->chassis && (!nbsp->up || *nbsp->up)) {
> > -            bool up = false;
> > +        bool up = sb->chassis ? true : false;
> > +        if (!nbsp->up || *nbsp->up != up) {
> >              nbrec_logical_switch_port_set_up(nbsp, &up, 1);
> >          }
> >      }
> > --
> > 2.9.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list