[ovs-dev] [PATCH 13/13] json: New function json_object_put_format().
blp at ovn.org
Mon Oct 9 20:18:55 UTC 2017
On Mon, Oct 09, 2017 at 04:08:54PM -0400, Russell Bryant wrote:
> On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff <blp at ovn.org> wrote:
> > This will acquire users in an upcoming commit.
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> > include/openvswitch/json.h | 6 +++++-
> > lib/json.c | 12 ++++++++++++
> > 2 files changed, 17 insertions(+), 1 deletion(-)
> Acked-by: Russell Bryant <russell at ovn.org>
Thanks for the review.
> Is it required to put the printf function attribute in both json.h and
> json.c? I figure it's harmless, but wasn't sure if it was necessary.
I don't know. On a related issue, I've noticed that Clang forgets about
thread safety annotations if they're not in both places. (Maybe that is
a bug, and maybe it's been fixed since I noticed it years ago.)
More information about the dev