[ovs-dev] [PATCH v5 0/6] netdev-dpdk: Fix management of pre-existing mempools.

[Kavanagh, Mark B]

>From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-bounces at openvswitch.org]
>On Behalf Of antonio.fischetti at intel.com
>Sent: Wednesday, October 11, 2017 5:01 PM
>To: dev at openvswitch.org
>Subject: [ovs-dev] [PATCH v5 0/6] netdev-dpdk: Fix management of pre-existing
>mempools.
>
>List of versions:
> - v5: manage new MTU value when a pre-existing mempool is returned.
> - v4: fix NUMA awareness usecase
> - v3: avoid deletion of pre-existing mempools
> - v2: rework to accomodate code changes for dpdk ports too
> - v1: 1st implementation.
>
>Fischetti, Antonio (6):
>  netdev-dpdk: fix management of pre-existing mempools.
>  netdev-dpdk: Fix mempool names to reflect socket id.
>  netdev-dpdk: skip init for existing mempools.
>  netdev-dpdk: assert mempool names.
>  netdev-dpdk: Reword mp_size as n_mbufs.
>  netdev-dpdk: Rename dpdk_mp_put as dpdk_mp_free.

Hi Antonio,

Some general comments on this patchset:
- patches 1 and 3 of the series should be squashed into one.
- patches 3-6 are purely cosmetic, and do not contribute to fixing the mempool reconfiguration mechanism;
  as such, they should be part of a separate patchset.
- initial testing has been successful; I'll send on final results as soon as they are available.

Thanks,
Mark


>
> lib/netdev-dpdk.c | 88 +++++++++++++++++++++++++++++++-----------------------
>-
> 1 file changed, 50 insertions(+), 38 deletions(-)
>
>--
>2.4.11
>
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://mail.openvswitch.org/mailman/listinfo/ovs-dev