[ovs-dev] [PATCH 0/2] OVN: Add support for periodic router advertisements

Mark Michelson mmichels at redhat.com
Wed Oct 18 16:53:47 UTC 2017

This patch series adds support for sending periodic router
advertisements from OVN. The patch is divided into two commits

* Commit 1 introduces a method to ensure that multicast packets are sent
  only to targets on the local hypervisor
* Commit 2 adds the ability to actually send the periodic RAs.

This patch series builds on the work in Numan Siddique's "ovn IPv6: Add
Router Solicitation responder support and generate Neighbor Solicitation
request for unknown" (patch series 6026 if using git-pw). Thus this
patch series cannot be merged until that patch series is merged first.

There are a couple of points I'd like to bring up with regards to this
patch that I would like addressed in reviews:

* I placed the logic for sending periodic RAs in pinctrl.c. My reasoning
  for this was that the closest thing that exists in OVN today is the
  periodic sending of gratuitous ARP requests, and that is in pinctrl.c.
  If periodic sending of RAs should be placed into a separate file,
  please let me know.
* In this patch, you will notice that a copy of the put_load() function
  from ovn/controller/physical.c has been placed in pinctrl.c. My choice
  was either to make the function public or duplicate it. Given that the
  function is so small, I see no reason why it would be modified, I went
  with the duplication choice. However, if it should be done the other
  way, let me know and I'll go that direction instead.

Mark Michelson (2):
  OVN: Add multicast keep-local flag.
  OVN: Add support for periodic router advertisements.

 lib/packets.h             |   4 +
 ovn/controller/physical.c |  15 ++
 ovn/controller/pinctrl.c  | 349 ++++++++++++++++++++++++++++++++++++++++++++++
 ovn/lib/logical-fields.h  |   6 +
 ovn/northd/ovn-northd.c   |  65 +++++++++
 ovn/ovn-nb.xml            |  19 +++
 tests/ovn-northd.at       | 110 +++++++++++++++
 tests/ovn.at              | 149 ++++++++++++++++++++
 8 files changed, 717 insertions(+)


More information about the dev mailing list