[ovs-dev] [PATCH] dpif-netdev: Initialize new rxqs in port_reconfigure().
blp at ovn.org
Fri Oct 27 17:33:29 UTC 2017
On Fri, Oct 27, 2017 at 12:04:01PM +0100, Kevin Traynor wrote:
> On 10/27/2017 12:49 AM, Ben Pfaff wrote:
> > valgrind reported use of uninitialized data in port_reconfigure(), which
> > was due to xrealloc() not initializing the newly added data, combined with
> > dp_netdev_rxq_set_intrvl_cycles() reading 'intrvl_idx' from the added data.
> > This avoids the warning.
> Thanks. Actually, with this change I can remove some of the other reset
> code also. Will send patch after PTO.
> Acked-by: Kevin Traynor <ktraynor at redhat.com>
Thanks for the review (impressive that you did it on PTO). I applied
this to master. It didn't apply to branch-2.8 so I'll assume that it
doesn't need backporting.
More information about the dev