[ovs-dev] [PATCH 3/4] ovn-sbctl: Fix dead assignment.

William Tu u9012063 at gmail.com
Mon Oct 30 17:27:54 UTC 2017


Clang reports value stored to 'sb' is never read.
Fix it by removing it.

Signed-off-by: William Tu <u9012063 at gmail.com>
---
 ovn/utilities/ovn-sbctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c
index 7af5863b08fc..c5ec4e6eaf24 100644
--- a/ovn/utilities/ovn-sbctl.c
+++ b/ovn/utilities/ovn-sbctl.c
@@ -1235,7 +1235,7 @@ do_sbctl(const char *args, struct ctl_command *commands, size_t n_commands,
     const struct sbrec_sb_global *sb = sbrec_sb_global_first(idl);
     if (!sb) {
         /* XXX add verification that table is empty */
-        sb = sbrec_sb_global_insert(txn);
+        sbrec_sb_global_insert(txn);
     }
 
     symtab = ovsdb_symbol_table_create();
-- 
2.7.4



More information about the dev mailing list