[ovs-dev] [PATCH v5 1/2] netdev-dpdk: extend netdev_dpdk_get_status to include if_type and if_descr

[Ben Pfaff]

On Mon, Oct 02, 2017 at 03:49:28PM +0100, Michal Weglicki wrote:
> This commit extends netdev_dpdk_get_status API to include additional
> driver-related information: if_type and if_descr.
> 
> v2->v3: Code rebase.
> v3->v4: Minor comments applied.
> 
> Co-authored-by: Michal Weglicki <michalx.weglicki at intel.com>
> Signed-off-by: Michal Weglicki <michalx.weglicki at intel.com>
> Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik at intel.com>

Thank you for this series.  It's always great to have more IPFIX support
and more status information for an interface.

I'm happy with this series, except for one thing that I noticed in this
particular patch: there is no documentation.  The various status keys
supported by dpdk should be documented in vswitch.xml near the existing
status keys, which currently start around line 2781:

      <column name="status">
        Key-value pairs that report port status.  Supported status values are
        <ref column="type"/>-dependent; some interfaces may not have a valid
        <ref column="status" key="driver_name"/>, for example.
      </column>

      <column name="status" key="driver_name">
        The name of the device driver controlling the network adapter.
      </column>

      <column name="status" key="driver_version">
        The version string of the device driver controlling the network
        adapter.
      </column>

and so on.  Since there are several for dpdk, maybe they should be
grouped together in a <group>...</group>.

I see that the existing dpdk status keys aren't documented either.  If
you can figure out what they are for, then it would be helpful to
document them too.

Thanks,

Ben.