[ovs-dev] [PATCH] netdev-dpdk: replace uint8_t with dpdk_port_t

[Kavanagh, Mark B]

>From: Ilya Maximets [mailto:i.maximets at samsung.com]
>Sent: Tuesday, October 31, 2017 6:46 AM
>To: Kavanagh, Mark B <mark.b.kavanagh at intel.com>; dev at openvswitch.org
>Subject: Re: [ovs-dev][PATCH] netdev-dpdk: replace uint8_t with dpdk_port_t
>
>Thanks. I wanted to remove this function initially, that's why I forget
>to replace the type here.
>
>This is important because dpdk changes the type of port_id to uint16_t
>for upcoming release.

Yes, exactly - that's how I detected this issue.
>
>Acked-by: Ilya Maximets <i.maximets at samsung.com>

Thanks Ilya!
Mark

>
>On 20.10.2017 15:37, Mark Kavanagh wrote:
>> netdev_dpdk_detach() declares a 'port_id' variable, of type uint8_t.
>> This variable should instead be of type dpdk_port_t.
>>
>> Fixes: bb37956ac ("netdev-dpdk: Use uint8_t for port_id.")
>> CC: Ilya Maximets <i.maximets at samsung.com>
>> Signed-off-by: Mark Kavanagh <mark.b.kavanagh at intel.com>
>> ---
>>  lib/netdev-dpdk.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
>> index c60f46f..1f6345d 100644
>> --- a/lib/netdev-dpdk.c
>> +++ b/lib/netdev-dpdk.c
>> @@ -2549,7 +2549,7 @@ netdev_dpdk_detach(struct unixctl_conn *conn, int argc
>OVS_UNUSED,
>>  {
>>      int ret;
>>      char *response;
>> -    uint8_t port_id;
>> +    dpdk_port_t port_id;
>>      char devname[RTE_ETH_NAME_MAX_LEN];
>>      struct netdev_dpdk *dev;
>>
>> --
>> 1.9.3
>>
>>
>>
>>