[ovs-dev] [PATCH] rhel.rst: Add python-sphinx as a dependency.

Aaron Conole aconole at redhat.com
Tue Oct 31 20:06:02 UTC 2017


Ben Pfaff <blp at ovn.org> writes:

> On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:
>> Ben Pfaff <blp at ovn.org> writes:
>> 
>> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:
>> >> Signed-off-by: Gurucharan Shetty <guru at ovn.org>
>> >> ---
>> >>  Documentation/intro/install/rhel.rst | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >> 
>> >> diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst
>> >> index 86c5cf3..aff6ccf 100644
>> >> --- a/Documentation/intro/install/rhel.rst
>> >> +++ b/Documentation/intro/install/rhel.rst
>> >> @@ -76,7 +76,7 @@ the below command::
>> >>  
>> >>      $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
>> >>          kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
>> >> -        libtool checkpolicy selinux-policy-devel
>> >> +        libtool checkpolicy selinux-policy-devel python-sphinx
>> >
>> > For Debian, we just recommend installing the build-dependencies listed
>> > in debian/control.  That has the advantage that it can't get out of
>> > date.  It has the disadvantage, though, that it's not easy to cut and
>> > paste (although "apt-get build-dep openvswitch" usually does the trick).
>> > Maybe "yum" has some mode that installs dependencies from a spec file?
>> 
>> For 'yum' distributions:
>> 
>>   yum-builddep
>> 
>> For 'dnf' distributions (newer Fedora, and future RHEL versions):
>> 
>>   dnf builddep
>
> Would it be reasonable to change rhel.rst to recommend using one of
> those tools, to ease future maintenance?

Sure.  Something like below?  I don't know about the wordsmithing, so
I'll defer that to Guru.

---

diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/
rhel.rst
index 86c5cf3..36bb661 100644
--- a/Documentation/intro/install/rhel.rst
+++ b/Documentation/intro/install/rhel.rst
@@ -72,11 +72,14 @@ Build Requirements
 
 To compile the RPMs, you will need to install the packages described in the
 :doc:`general` along with some additional packages. These can be installed with
-the below command::
+the below command for ``yum`` based distributions (but note that the
+openvswitch source RPM must be available somewhere)::
 
-    $ yum install gcc make python-devel openssl-devel kernel-devel graphviz \
-        kernel-debug-devel autoconf automake rpm-build redhat-rpm-config \
-        libtool checkpolicy selinux-policy-devel
+    $ yum-builddep openvswitch
+
+For ``dnf`` based distributions, use the following command::
+
+    $ dnf builddep rhel/openvswitch-fedora.spec
 
 .. _rhel-bootstrapping:
--


More information about the dev mailing list