[ovs-dev] [PATCH 2/2] xlate: normalize the actions after translation

Ben Pfaff blp at ovn.org
Tue Oct 31 20:29:41 UTC 2017


On Mon, Oct 30, 2017 at 12:22:50PM +0100, Zoltan Balogh wrote:
> When all OF actions have been translated, there could be actions at
> the end of list of odp actions which are not needed to be executed.
> So, the list can be normalized at the end of xlate_actions().
> 
> Signed-off-by: Zoltan Balogh <zoltan.balogh at ericsson.com>
> Signed-off-by: Sugesh Chandran <sugesh.chandran at intel.com>
> Co-authored-by: Sugesh Chandran <sugesh.chandran at intel.com>
> Tested-by: Sugesh Chandran <sugesh.chandran at intel.com>

Thanks for working on this.  I wasn't previously aware that there was a
problem, but now I see what you mean.

The description in 0/2 is necessary to properly understand the problem,
but that description will get lost when the patches are committed.  I
recommend adding all or most of it to patch 1.

This approach to saving and restoring is going to be super-expensive
during translation.  On i386, struct xlate_backup_data is 1996 bytes,
and as I read the patch, that's getting copied every time we visit a new
OpenFlow table.  Do you have any idea about how to make it cheaper, or
how to make fewer backups?

Thanks,

Ben.


More information about the dev mailing list