[ovs-dev] [RFC PATCH v2 04/10] flow: Add ESP spi value to flow struct.

[Ben Pfaff]

On Tue, Oct 31, 2017 at 02:46:15PM -0700, Ben Pfaff wrote:
> On Fri, Aug 25, 2017 at 05:40:26PM +0100, Ian Stokes wrote:
> > This patch adds a field to the flow struct to represent the ESP security
> > parameter index of a packet.
> > 
> > Signed-off-by: Ian Stokes <ian.stokes at intel.com>
> > ---
> >  include/openvswitch/flow.h |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/openvswitch/flow.h b/include/openvswitch/flow.h
> > index a658a58..d986929 100644
> > --- a/include/openvswitch/flow.h
> > +++ b/include/openvswitch/flow.h
> > @@ -156,6 +156,11 @@ struct flow {
> >      ovs_be32 igmp_group_ip4;    /* IGMP group IPv4 address.
> >                                   * Keep last for BUILD_ASSERT_DECL below. */
> >      ovs_be32 pad3;              /* Pad to 64 bits. */
> > +
> > +    /* SPI for ESP (64-bit aligned) */
> > +    /* XXX TO DO: move this to the l3 layer */
> > +    ovs_be32 spi;
> > +    ovs_be32 pad4;
> >  };
> 
> I'd like to see this moved to the L3 layer (as your comment says).

Actually, I think I take that back.  Isn't this logically part of L4?
(If so, then 'spi' can replace 'pad3' instead of being a doubleword of
its own.)