[ovs-dev] [PATCH 7/9] flow: Refactor parse_ct_state()

Ben Pfaff blp at ovn.org
Tue Oct 31 22:25:53 UTC 2017


On Fri, Aug 25, 2017 at 03:51:17PM -0700, Yi-Hung Wei wrote:
> Refactor parse_ct_state() to support different delimiters.
> 
> Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>
> ---
>  lib/flow.c                   | 6 +++---
>  lib/flow.h                   | 2 +-
>  ofproto/ofproto-dpif-trace.c | 2 +-
>  ovn/utilities/ovn-trace.c    | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/flow.c b/lib/flow.c
> index b2b10aa488be..34bc176e8b6e 100644
> --- a/lib/flow.c
> +++ b/lib/flow.c
> @@ -1129,14 +1129,14 @@ ct_state_from_string(const char *s)
>   * returns false, and reports error message in 'ds'. */
>  bool
>  parse_ct_state(const char *state_str, uint32_t default_state,
> -               uint32_t *ct_state, struct ds *ds)
> +               const char *delimiters, uint32_t *ct_state, struct ds *ds)

Thanks for working on this.

parse_ct_state() has a pretty good function-level comment, so would you
mind updating it to mention the new parameter?

Thanks,

Ben.


More information about the dev mailing list