[ovs-dev] [PATCH 0/2] fix odp parsing of set masked action

[Roi Dayan]

On 07/09/2017 01:22, Greg Rose wrote:
> On 09/03/2017 10:19 PM, Roi Dayan wrote:
>>
>>
>> On 29/08/2017 07:30, Roi Dayan wrote:
>>> Hi,
>>>
>>> The first commit is a fix for parsing set masked action
>>> and the second commit is adding a test.
>>>
>>> Before the fix the addtion of the tests fails with the following:
>>> # make check TESTSUITEFLAGS=436
>>> # ./tests/ovstest test-odp parse-actions < 
>>> ./tests/testsuite.dir/0436/actions.txt > outact && diff -up 
>>> ./tests/testsuite.dir/0436/actions.txt  outact
>>> --- ./tests/testsuite.dir/0436/actions.txt      2017-08-27 
>>> 11:12:05.169261080 +0300
>>> +++ outact      2017-08-27 11:20:21.175169197 +0300
>>> @@ -47,11 +47,11 @@ set(ipv6(label=0,proto=10,hlimit=128))
>>>   set(ipv6(label=0/0xfff,proto=10,tclass=0x70/0x70))
>>>   set(ipv6(label=0))
>>>   set(icmpv6(type=1,code=2))
>>> -set(vlan(vid=5))
>>> +set(vlan(vid=5/0x0))
>>>   set(vlan(vid=3,pcp=5))
>>>   set(vlan(vid=3,pcp=5,cfi=0))
>>> -set(vlan(vid=5/0x3))
>>> -set(vlan(vid=5/0x1)),3
>>> +set(vlan(vid=5/0x0))
>>> +set(vlan(vid=5/0x0)),***6 leftover bytes*** (010003000000)
>>>   push_vlan(vid=12,pcp=0)
>>>   push_vlan(vid=13,pcp=5,cfi=0)
>>>   push_vlan(tpid=0x9100,vid=13,pcp=5)
>>>
>>> Thanks,
>>> Roi
>>>
>>>
>>> Paul Blakey (2):
>>>    lib/odp: Fix handling of set masked action in parse_odp_action
>>>    tests/odp: Add set vlan test to odp testsuite
>>>
>>>   lib/odp-util.c | 9 +++++++++
>>>   tests/odp.at   | 5 +++++
>>>   2 files changed, 14 insertions(+)
>>>
>>
>> hi,
>>
>> just pinging
>>
>> thanks
> 
> Are you waiting for Simon to review this series and the other patch you 
> pinged the list about?
> Simon is on the 'to:' line so I figured you wanted his review.
> 
> Regards,
> 
> - Greg

Hi Greg,

Doesn't matter who does the review really. Since Simon and Joe
were main reviewers on the hw-offload feature, I'm usually
adding them to related patches.

Thanks,
Roi


> 
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>