[ovs-dev] [PATCH v2 6/8] netdev-dpdk: retry with queue action

Yuanhan Liu yliu at fridaylinux.org
Mon Sep 11 06:14:25 UTC 2017


On Fri, Sep 08, 2017 at 06:48:50PM +0200, Simon Horman wrote:
> On Tue, Sep 05, 2017 at 05:22:59PM +0800, Yuanhan Liu wrote:
> > From: Finn Christensen <fc at napatech.com>
> > 
> > AFAIK, most (if not all) NICs (including Mellanox and Intel) do not
> > support a pure MARK action.  It's required to be used together with
> > some other actions, like QUEUE.
> > 
> > To workaround it, retry with a queue action when first try failed.
> > 
> > Moreover, some Intel's NIC (say XL710) needs the QUEUE action set
> > before the MARK action.
> > 
> > Co-authored-by: Yuanhan Liu <yliu at fridaylinux.org>
> > Signed-off-by: Finn Christensen <fc at napatech.com>
> > Signed-off-by: Yuanhan Liu <yliu at fridaylinux.org>
> 
> This feels a bit like the tail wagging the dog.
> Is this the lowest level at which it makes sense to implement
> this logic?
> 
> If so then I wonder if some sort of probing would be in order
> to avoid the cost of trying to add the flow twice to hardware
> where the queue is required.

Do you mean something like rte_flow capability query, like whether
a queue action is needed for a mark action? If so, yes, I do think
we miss an interface like this.

Note that even in this solution, the flow won't be created twice
to the hardware, because the first try would be failed.

	--yliu


More information about the dev mailing list