[ovs-dev] [PATCH] tests: Skip OVN test if truncate command not found

Mark Michelson mmichels at redhat.com
Mon Sep 11 20:05:24 UTC 2017


On Mon, Sep 11, 2017 at 2:59 PM Mark Michelson <mmichels at redhat.com> wrote:

> On Mon, Sep 11, 2017 at 2:37 PM Alin Gabriel Serdean <aserdean at ovn.org>
> wrote:
>
>> Test: "testing ovn -- ensure one gw controller restart in HA doesn't
>> bounce the master" uses the command `truncate`.
>>
>> Skip the test if the command is not found.
>>
>>
> The use of the truncate command here is to make the file 0 bytes. Rather
> than skipping the test if the truncate command is not present, the test
> could be altered to make the file 0 bytes in some other way.
>
> # dd if=/dev/null of=gw1/ovn-controller.log
> # > gw1-controller.log
> # rm gw1-controller.log && touch gw1/ovn-controller.log
>
> Are potential ways of expressing the same thing without needing to use
> truncate.
>

OOps, I typoed the filename in those last two suggestions. They should be

# > gw1/ovn-controller.log
# rm gw1/ovn-controller.log && touch gw1/ovn-controller.log


More information about the dev mailing list