[ovs-dev] [PATCH] tests: Skip OVN test if truncate command not found

Mark Michelson mmichels at redhat.com
Mon Sep 11 20:59:10 UTC 2017


On Mon, Sep 11, 2017 at 3:37 PM Alin Serdean <
aserdean at cloudbasesolutions.com> wrote:

> > On Mon, Sep 11, 2017 at 2:59 PM Mark Michelson <mmichels at redhat.com>
> > wrote:
> >
> > > On Mon, Sep 11, 2017 at 2:37 PM Alin Gabriel Serdean
> > > <aserdean at ovn.org>
> > > wrote:
> > >
> > >> Test: "testing ovn -- ensure one gw controller restart in HA doesn't
> > >> bounce the master" uses the command `truncate`.
> > >>
> > >> Skip the test if the command is not found.
> > >>
> > >>
> > > The use of the truncate command here is to make the file 0 bytes.
> > > Rather than skipping the test if the truncate command is not present,
> > > the test could be altered to make the file 0 bytes in some other way.
> > >
> > > # dd if=/dev/null of=gw1/ovn-controller.log # > gw1-controller.log #
> > > rm gw1-controller.log && touch gw1/ovn-controller.log
> > >
> > > Are potential ways of expressing the same thing without needing to use
> > > truncate.
> > >
> >
> > OOps, I typoed the filename in those last two suggestions. They should be
> >
> > # > gw1/ovn-controller.log
> > # rm gw1/ovn-controller.log && touch gw1/ovn-controller.log
> > _______________________________________________
> [Alin Serdean] Thanks for the quick review Mark!
> Sorry I didn't look at the actual test.
> I just saw it failed and:
> "ovs/tests/testsuite.dir/at-groups/2364/test-source: line 82: truncate:
> command not found"
> in the log.
> Short story msys does not have truncate, msys2 has it that's why I was so
> eager 😊.
>
> I would avoid using dd with /dev/null because that would also a bit
> specific.
>
> I tested with the following
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 2a00232..572102b 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -8501,7 +8501,8 @@ ovn-nbctl --wait=hv --timeout=3 sync
>  # doesn't have the same effect because "name" is conserved, and the
>  # Chassis entry is not replaced.
>
> -truncate -s 0 gw1/ovn-controller.log
> +#truncate -s 0 gw1/ovn-controller.log
> +> gw1/ovn-controller.log
>
>  gw2_chassis=$(ovn-sbctl --bare --columns=_uuid find Chassis name=gw2)
>  ovn-sbctl destroy Chassis $gw2_chassis
>
> Do you mind sending out a patch for it?
>
> Alin.
>

Patch is here:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-September/338627.html


More information about the dev mailing list