[ovs-dev] [PATCH] test: Avoid using 'truncate' command

aserdean at ovn.org aserdean at ovn.org
Mon Sep 11 23:53:47 UTC 2017


Thanks Mark! I applied this on master and branch-2.8.

Ben: Thanks for the encouragement 😊.

Alin.
> -----Original Message-----
> From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> bounces at openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Tuesday, September 12, 2017 2:03 AM
> To: aserdean at ovn.org
> Cc: dev at openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] test: Avoid using 'truncate' command
> 
> Alin, since Mark isn't a committer, and you are, it's probably best to just apply
> this yourself.
> 
> On Tue, Sep 12, 2017 at 12:55:35AM +0300, aserdean at ovn.org wrote:
> > Tested-by: Alin Gabriel Serdean <aserdean at ovn.org>
> > Acked-by: Alin Gabriel Serdean <aserdean at ovn.org>
> >
> > > -----Original Message-----
> > > From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> > > bounces at openvswitch.org] On Behalf Of Mark Michelson
> > > Sent: Monday, September 11, 2017 11:58 PM
> > > To: dev at openvswitch.org
> > > Subject: [ovs-dev] [PATCH] test: Avoid using 'truncate' command
> > >
> > > The 'truncate' command is not available on all platforms. Since the
> > command
> > > was being used to zero out a file, there are other easy options available.
> > In
> > > this case, I've replaced 'truncate' with a redirection.
> > >
> > > Reported-by: Alin Gabriel Serdean <aserdean at ovn.org>
> > > Signed-off-by: Mark Michelson <mmichels at redhat.com>



More information about the dev mailing list