[ovs-dev] [PATCH 07/10] odp-execute: Use const qualifer for batch size.

Bhanuprakash Bodireddy bhanuprakash.bodireddy at intel.com
Tue Sep 19 19:29:01 UTC 2017


It is recommended to use const qualifer for 'num' that tracks the
packet batch count. This way 'num' can't be modified by iterator.

Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy at intel.com>
---
 lib/odp-execute.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 5f4d23a..3109f39 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -826,7 +826,8 @@ odp_execute_actions(void *dp, struct dp_packet_batch *batch, bool steal,
             break;
         }
         case OVS_ACTION_ATTR_DECAP_NSH: {
-            size_t i, num = batch->count;
+            size_t i;
+            const size_t num = dp_packet_batch_size(batch);
 
             DP_PACKET_BATCH_REFILL_FOR_EACH (i, num, packet, batch) {
                 if (decap_nsh(packet)) {
-- 
2.4.11



More information about the dev mailing list