[ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported by clang.

Darrell Ball dball at vmware.com
Tue Sep 19 20:29:36 UTC 2017


Thanks Bhanu

It seems my scan-build usage was not catching these.
I decided to do something a little different which I’ll send out later today as part of some other changes

Darrell

On 9/10/17, 10:25 AM, "Bodireddy, Bhanuprakash" <bhanuprakash.bodireddy at intel.com> wrote:

    Hi Darrell,
    
    >What version of clang are you using and in what environment ?
    
    The clang version is  3.5.0. This was seen with clang static analysis.
    
    - Bhanuprakash.
    
    >
    >On 9/8/17, 10:59 AM, "ovs-dev-bounces at openvswitch.org on behalf of
    >Bhanuprakash Bodireddy" <ovs-dev-bounces at openvswitch.org on behalf of
    >bhanuprakash.bodireddy at intel.com> wrote:
    >
    >    Clang reports that value stored to ftp, seq_skew_dir never read inside
    >    the function.
    >
    >    Signed-off-by: Bhanuprakash Bodireddy
    ><bhanuprakash.bodireddy at intel.com>
    >    ---
    >     lib/conntrack.c | 5 ++---
    >     1 file changed, 2 insertions(+), 3 deletions(-)
    >
    >    diff --git a/lib/conntrack.c b/lib/conntrack.c
    >    index 419cb1d..a0838ee 100644
    >    --- a/lib/conntrack.c
    >    +++ b/lib/conntrack.c
    >    @@ -2615,7 +2615,7 @@ process_ftp_ctl_v4(struct conntrack *ct,
    >         char ftp_msg[LARGEST_FTP_MSG_OF_INTEREST + 1] = {0};
    >         get_ftp_ctl_msg(pkt, ftp_msg);
    >
    >    -    char *ftp = ftp_msg;
    >    +    char *ftp;
    >         enum ct_alg_mode mode;
    >         if (!strncasecmp(ftp_msg, FTP_PORT_CMD, strlen(FTP_PORT_CMD))) {
    >             ftp = ftp_msg + strlen(FTP_PORT_CMD);
    >    @@ -2761,7 +2761,7 @@ process_ftp_ctl_v6(struct conntrack *ct,
    >         get_ftp_ctl_msg(pkt, ftp_msg);
    >         *ftp_data_start = tcp_hdr + tcp_hdr_len;
    >
    >    -    char *ftp = ftp_msg;
    >    +    char *ftp;
    >         struct in6_addr ip6_addr;
    >         if (!strncasecmp(ftp_msg, FTP_EPRT_CMD, strlen(FTP_EPRT_CMD))) {
    >             ftp = ftp_msg + strlen(FTP_EPRT_CMD);
    >    @@ -2909,7 +2909,6 @@ handle_ftp_ctl(struct conntrack *ct, const struct
    >conn_lookup_ctx *ctx,
    >         bool seq_skew_dir;
    >         if (ftp_ctl == CT_FTP_CTL_OTHER) {
    >             seq_skew = conn_for_expectation->seq_skew;
    >    -        seq_skew_dir = conn_for_expectation->seq_skew_dir;
    >         } else if (ftp_ctl == CT_FTP_CTL_INTEREST) {
    >             enum ftp_ctl_pkt rc;
    >             if (ctx->key.dl_type == htons(ETH_TYPE_IPV6)) {
    >    --
    >    2.4.11
    >
    >    _______________________________________________
    >    dev mailing list
    >    dev at openvswitch.org
    >    https://urldefense.proofpoint.com/v2/url?u=https-
    >3A__mail.openvswitch.org_mailman_listinfo_ovs-
    >2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-
    >uZnsw&m=LE5PLIlvBSFThteUGJevgTlRlFesohyngSzGDqpvk5k&s=BsQfIBSohBf
    >sM_UTvU-fZeE6EswgpKmd9tz0snT8usc&e=
    >
    
    





More information about the dev mailing list