[ovs-dev] [PATCH RFC 30/52] jsonrpc-server: Report monitor session ID properly in error message.

Ben Pfaff blp at ovn.org
Tue Sep 19 22:01:03 UTC 2017


The error message in question is about the monitor session ID but it
actually reports the JSON-RPC request ID instead, which is surprising.

Found by inspection.

Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 ovsdb/jsonrpc-server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c
index 555f87e55f3e..6e5f75498fc1 100644
--- a/ovsdb/jsonrpc-server.c
+++ b/ovsdb/jsonrpc-server.c
@@ -1415,7 +1415,7 @@ ovsdb_jsonrpc_monitor_cond_change(struct ovsdb_jsonrpc_session *s,
 
     m = ovsdb_jsonrpc_monitor_find(s, params->u.array.elems[0]);
     if (!m) {
-        error = ovsdb_syntax_error(request_id, NULL,
+        error = ovsdb_syntax_error(params->u.array.elems[0], NULL,
                                    "unknown monitor session");
         goto error;
     }
-- 
2.10.2



More information about the dev mailing list