[ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif: Unfreeze within clone

Andy Zhou azhou at ovn.org
Tue Sep 19 23:11:45 UTC 2017


On Tue, Sep 19, 2017 at 1:56 PM, Greg Rose <gvrose8192 at gmail.com> wrote:
> On 09/19/2017 01:26 PM, Andy Zhou wrote:
>>
>> On Tue, Sep 19, 2017 at 9:55 AM, Greg Rose <gvrose8192 at gmail.com> wrote:
>>>
>>> On 09/12/2017 12:49 PM, Andy Zhou wrote:
>>>>
>>>>
>>>> When translating actions within open flow clone, actions generated
>>>> by finish_freezeing() should also be enclosed within the datapath
>>>> clone netlink encoding.
>>>>
>>>> Signed-off-by: Andy Zhou <azhou at ovn.org>
>>>
>>>
>>>
>>> Andy,
>>>
>>> I am reviewing and testing your patches.  I have applied them to my
>>> private
>>> github repository
>>> on a branch named test-813027-35.
>>>
>>> https://github.com/gvrose8192/ovs-experimental/tree/test-813027-35
>>>
>>> However, the Travis 'TESTSUITE=1 KERNEL=3.16.46 build fails:
>>>
>>> https://travis-ci.org/gvrose8192/ovs-experimental/jobs/277364409
>>>
>>> Have you noticed this as well?
>>
>>
>> No. It passed my local test, and passed travis test from my private
>> branch (just rebased this morning)
>>
>> https://github.com/azhou-nicira/ovs-review/tree/patch_port
>>
>> https://travis-ci.org/azhou-nicira/ovs-review/builds/277412765
>>
>> (The --disable-ssl build is slow for some reason, same as master).
>>
>> May be this is caused by travis running slow for some reason?
>>
>> Did your local test pass?
>>
>
> Yes, I just tried on a VM running Centos 7.3 with the 4.9 kernel and it
> passed there.
>
> /shrug?
>
> OK, I'll continue with review then.
>
> Thanks!
>
> - Greg

FWIW. the --disable-ssl build finally passed. The total build/test
time is 4hr 42min.
Travis CI is definitely slow today.


More information about the dev mailing list