[ovs-dev] [PATCH V2] netdev-tc-offloads: Fix vxlan tunnel offloading

Simon Horman simon.horman at netronome.com
Wed Sep 20 07:17:47 UTC 2017


On Wed, Sep 13, 2017 at 05:04:58PM +0300, Roi Dayan wrote:
> From: Paul Blakey <paulb at mellanox.com>
> 
> This commit fixes offloading when tunnel id is 0 by checking
> for valid tunnel dst ipv4 or ipv6, like done in the normal flow.
> 
> Also need to reset the tunnel mask outside the condition
> because in the special case, when adding a port with key=flow,
> the match for tunnel_set gets a tunnel key id 0 with a mask.
> If we don't reset the mask we'll fail later when we check
> for unknown attributes that the mask was not reset.
> 
> Fixes: 8f283af89298 ("netdev-tc-offloads: Implement netdev flow put using tc interface")
> Signed-off-by: Paul Blakey <paulb at mellanox.com>
> Reviewed-by: Roi Dayan <roid at mellanox.com>
> ---
> Hi,
> 
> This is V2 for the prev patch with
> title "netdev-tc-offloads: Fix offloading when tunnel id is 0"
> 
> V1->V2:
>     - Use flow_tnl_dst_is_set() instead of checking mask
>     - Move memset of maks tunnel to outside the condition
>     - Update commit message

Thanks, applied to master and branch-2.8.


More information about the dev mailing list