[ovs-dev] [PATCH v2] dpif-netdev: Set MAX_RECIRC_DEPTH to 6.

Darrell Ball dball at vmware.com
Fri Sep 22 04:11:12 UTC 2017


Hi Guoshuai

It looks like when you committed the patch locally you missed  ‘—signoff’.
A valid patch must have a signoff.

Also, it would be good to have Ben take a look at this.

Thanks Darrell


On 9/21/17, 12:32 AM, "ovs-dev-bounces at openvswitch.org on behalf of Guoshuai Li" <ovs-dev-bounces at openvswitch.org on behalf of ligs at dtdream.com> wrote:

    In an ovn gateway node with DPDK, the RECIRC_DEPTH may be greater than 5.
    
    Scenes:
    VM ping self floating IP, or
    VM ping Floating IP of VMs with the same network.
    
    It need process UNDNAT SNAT in LRouter egress and
    UNSNAT DNAT in LRouter ingress, and
    output to geneve tunnel also need recirc.
    
    This has an WARN:
    dpif_netdev(pmd36)|WARN|Packet dropped. Max recirculation depth exceeded.
    ---
    
    v2: change recirc depth from 10 to 6.
    
    ---
     lib/dpif-netdev.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
    index ca74df8c7..a0f620a5c 100644
    --- a/lib/dpif-netdev.c
    +++ b/lib/dpif-netdev.c
    @@ -82,7 +82,7 @@ VLOG_DEFINE_THIS_MODULE(dpif_netdev);
     
     #define FLOW_DUMP_MAX_BATCH 50
     /* Use per thread recirc_depth to prevent recirculation loop. */
    -#define MAX_RECIRC_DEPTH 5
    +#define MAX_RECIRC_DEPTH 6
     DEFINE_STATIC_PER_THREAD_DATA(uint32_t, recirc_depth, 0)
     
     /* Configuration parameters. */
    -- 
    2.13.2.windows.1
    
    _______________________________________________
    dev mailing list
    dev at openvswitch.org
    https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=IVqd6IG5yxw8TLZISmSerVb-lVPbEBqGglgf8-Cpo3E&s=RrLHyC0Qor03UPs7tgt5MY2KxenRy4JRYexo8t49V6M&e= 
    



More information about the dev mailing list